Skip to content

Conversation

@alinpahontu2912
Copy link
Member

Fixes #1374

@alinpahontu2912 alinpahontu2912 requested a review from a user March 18, 2025 12:36
ghost
ghost previously approved these changes Mar 19, 2025
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for also adding additional unit tests to cover the scenario as we've discussed before.

I left one nice to have suggestion comment.

@alinpahontu2912 alinpahontu2912 requested a review from a user March 20, 2025 08:57
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 3701fc5 into dotnet:main Mar 27, 2025
2 checks passed
@alinpahontu2912 alinpahontu2912 deleted the index_put_fix branch August 9, 2025 19:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add accumulate to index_put_

1 participant